Fix reviewers sometimes receiving email they shouldn't

Review Request #7663 — Created Sept. 28, 2015 and submitted

brennie
Review Board
release-2.0.x
3985
reviewboard

Previously, the should_send_own_updates code was not implemented
correctly. If a user had that setting set to False and created a
review request that had a target group that contained themselves and
another target user, then reviewing the review request would cause them
to receive e-mail. This issue has been fixed. A unit test has bee
added to ensure this behaviour does not regress.

Ran unit tests.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/email.py
        reviewboard/notifications/tests.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
brennie
brennie
brennie
Review request changed

Status: Closed (submitted)

  1. 
      
  2. reviewboard/notifications/tests.py (Diff revision 1)
     
     

    Typo: This comment should probably also be updated to be 3985.

  3. 
      
Loading...