Summary

Fix reviewers sometimes receiving email they shouldn't

Review Request #7663 — Created Sept. 28, 2015 and submitted Sept. 28, 2015, 6:15 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

3985

Depends On

Reviewers

Groups

reviewboard

People

Description

Previously, the should_send_own_updates code was not implemented
correctly. If a user had that setting set to False and created a
review request that had a target group that contained themselves and
another target user, then reviewing the review request would cause them
to receive e-mail. This issue has been fixed. A unit test has bee
added to ensure this behaviour does not regress.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Typo: This comment should probably also be updated to be 3985.	AD adriano	Oct. 16, 2015, 8:49 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (7755109)

Status:: Re-opened

Bugs:: 3895
3985

Status:: Completed

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: This comment should probably also be updated to be 3985.
```