Add the initial structure around rbpkg.

Review Request #7657 — Created Sept. 24, 2015 and submitted

chipx86
rbpkg
master
rbpkg
This adds the command structure for rbpkg, the new package installer for
Review Board. Right now, there aren't any commands available, but those
will come later.

rbpkg's command structure is modeled heavily off of RBTools.

Some may wonder why we're building our own installer, so I provided a
bunch of rationalization in the README.md.

Ran rbpkg. Got help output.

There are no commands yet, so.. we'll see how well it works in practice!

Description From Last Updated

Typo -- dependencies.

gmyersgmyers

", largely because ...."

brenniebrennie

" -- and will soon require -- "

brenniebrennie

typo and grammar "modules, but this does not work for us for a number of reasons"

brenniebrennie

No comma.

brenniebrennie

"PyPI doesn't really allow this if we host all our packages there."

brenniebrennie

"storing our packages"

brenniebrennie

I don't think "all-too-frequently" should be hyphenated.

AD adriano

"... from PyPI over HTTPS and ..." (or use parenthesis around "over HTTPS")

brenniebrennie

No comma

brenniebrennie

"It only works with our official, maintained, and signed list of packages. This way you always know you're getting our ...

brenniebrennie

s/getting/installing ?

brenniebrennie

No comma needed.

CH chronicleyu

" rbpkg "

brenniebrennie

"Public" should be lowercase.

AD adriano

add_argument

brenniebrennie

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

"command"

brenniebrennie

'find_packages' imported but unused

reviewbotreviewbot

'is_release' imported but unused

reviewbotreviewbot

'VERSION' imported but unused

reviewbotreviewbot

Can we also add *.swp?

daviddavid

Typo (nam -> name)

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
  2. rbpkg/commands/base.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  3. setup.py (Diff revision 1)
     
     
     'find_packages' imported but unused
    
  4. setup.py (Diff revision 1)
     
     
     'is_release' imported but unused
    
  5. setup.py (Diff revision 1)
     
     
     'VERSION' imported but unused
    
  6. 
      
brennie
  1. <p>Typo in your description: "modelled"</p>

  2. README.md (Diff revision 1)
     
     
     

    ", largely because ...."

  3. README.md (Diff revision 1)
     
     
     

    " -- and will soon require -- "

  4. README.md (Diff revision 1)
     
     

    typo and grammar

    "modules, but this does not work for us for a number of reasons"

  5. README.md (Diff revision 1)
     
     

    No comma.

    1. This is one of those cases where I'm using a comma to pause for, I guess, emphasis, like if I'm speaking out loud: "geared toward showing the latest few versions of a package... and becomes a barrier for the users we work with."

  6. README.md (Diff revision 1)
     
     
     

    "PyPI doesn't really allow this if we host all our packages there."

  7. README.md (Diff revision 1)
     
     

    "storing our packages"

  8. README.md (Diff revision 1)
     
     

    "... from PyPI over HTTPS and ..." (or use parenthesis around "over HTTPS")

  9. README.md (Diff revision 1)
     
     

    No comma

  10. README.md (Diff revision 1)
     
     

    "It only works with our official, maintained, and signed list of packages. This way you always know you're getting our stuff."

  11. README.md (Diff revision 1)
     
     

    s/getting/installing ?

  12. README.md (Diff revision 1)
     
     

    " rbpkg "

    1. I'm not sure what you're saying here.

    2. I think that Barret recommends that you surround rbpkg with backticks, so that it renders in monospaced font.

    3. Ah. In this case, it's the name given to this, not the executable name. Same reason I don't put backticks around "pip" everywhere I mention it.

  13. rbpkg/commands/base.py (Diff revision 1)
     
     

    add_argument

  14. rbpkg/commands/main.py (Diff revision 1)
     
     

    "command"

    1. My 'e', 'd', an 'r' keys are not reliable right now :(

  15. 
      
gmyers
  1. 
      
  2. README.md (Diff revision 1)
     
     
    Typo -- dependencies.
  3. 
      
AD
  1. 
      
  2. README.md (Diff revision 1)
     
     

    Instead of "for many good reason", consider using either "for good reason" or "for many good reasons".

    1. 's' is part of a cluster of keys that aren't working well on my keyboard. :(

  3. README.md (Diff revision 1)
     
     

    I don't think "all-too-frequently" should be hyphenated.

  4. README.md (Diff revision 1)
     
     

    "Public" should be lowercase.

  5. 
      
CH
  1. 
      
  2. README.md (Diff revision 1)
     
     

    No comma needed.

  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
  2. 
      
david
  1. 
      
  2. .gitignore (Diff revision 2)
     
     

    Can we also add *.swp?

  3. rbpkg/commands/main.py (Diff revision 2)
     
     

    Typo (nam -> name)

  4. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbpkg/commands/main.py
        rbpkg/__init__.py
        setup.py
        rbpkg/commands/base.py
    
    Ignored Files:
        rbpkg/commands/__init__.py
        MANIFEST.in
        .gitignore
        .reviewboardrc
        COPYING
        AUTHORS
        README.md
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...