Add the initial structure around rbpkg.
Review Request #7657 — Created Sept. 24, 2015 and submitted
This adds the command structure for rbpkg, the new package installer for Review Board. Right now, there aren't any commands available, but those will come later. rbpkg's command structure is modeled heavily off of RBTools. Some may wonder why we're building our own installer, so I provided a bunch of rationalization in the README.md.
Ran rbpkg. Got help output.
There are no commands yet, so.. we'll see how well it works in practice!
Description | From | Last Updated |
---|---|---|
Typo -- dependencies. |
gmyers | |
", largely because ...." |
brennie | |
" -- and will soon require -- " |
brennie | |
typo and grammar "modules, but this does not work for us for a number of reasons" |
brennie | |
No comma. |
brennie | |
"PyPI doesn't really allow this if we host all our packages there." |
brennie | |
"storing our packages" |
brennie | |
I don't think "all-too-frequently" should be hyphenated. |
AD adriano | |
"... from PyPI over HTTPS and ..." (or use parenthesis around "over HTTPS") |
brennie | |
No comma |
brennie | |
"It only works with our official, maintained, and signed list of packages. This way you always know you're getting our … |
brennie | |
s/getting/installing ? |
brennie | |
No comma needed. |
CH chronicleyu | |
" rbpkg " |
brennie | |
"Public" should be lowercase. |
AD adriano | |
add_argument |
brennie | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
"command" |
brennie | |
'find_packages' imported but unused |
reviewbot | |
'VERSION' imported but unused |
reviewbot | |
'is_release' imported but unused |
reviewbot | |
Can we also add *.swp? |
david | |
Typo (nam -> name) |
david |
- Change Summary:
-
- Fixed various typos and other issues in the README.
- Fixed Review Bot complaints.
- Diff:
-
Revision 2 (+604)
-
Tool: Pyflakes Processed Files: rbpkg/commands/main.py rbpkg/__init__.py setup.py rbpkg/commands/base.py Ignored Files: rbpkg/commands/__init__.py MANIFEST.in .gitignore .reviewboardrc COPYING AUTHORS README.md Tool: PEP8 Style Checker Processed Files: rbpkg/commands/main.py rbpkg/__init__.py setup.py rbpkg/commands/base.py Ignored Files: rbpkg/commands/__init__.py MANIFEST.in .gitignore .reviewboardrc COPYING AUTHORS README.md
- Change Summary:
-
- Fixed typos.
- Fixed help output.
- Added
.*.swp
files to.gitignore
.
- Diff:
-
Revision 3 (+604)
-
Tool: Pyflakes Processed Files: rbpkg/commands/main.py rbpkg/__init__.py setup.py rbpkg/commands/base.py Ignored Files: rbpkg/commands/__init__.py MANIFEST.in .gitignore .reviewboardrc COPYING AUTHORS README.md Tool: PEP8 Style Checker Processed Files: rbpkg/commands/main.py rbpkg/__init__.py setup.py rbpkg/commands/base.py Ignored Files: rbpkg/commands/__init__.py MANIFEST.in .gitignore .reviewboardrc COPYING AUTHORS README.md