Fix the DiffCommitIndexView to no longer use hoverIntent

Review Request #7652 — Created Sept. 20, 2015 and submitted

brennie
Review Board
dvcs
reviewboard

The hoverIntent jQuery plugin was removed as a dependency on the
release-2.5.x branch and that change was eventually merged into the
dvcs branch. However, the DiffCommitIndexView utilized this plugin.
The view has been reworked to no longer depend on it and a bit of
cleanup has occurred.

Verified that the summaries expanded in the diff viewer.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js
    
    
  2. 
      
brennie
david
  1. 
      
  2. Can we keep the -s and +s lined up with the other parts of the equation instead of the =?

    1. Ok. I had reindented it to be only 4 spaces in relative to start of line.

    2. In this case, because it's a continuation that's logically grouped with the stuff to the right of the = sign, I think it makes sense to keep it all to the right of the = sign. This is similar to how we indent other method call parameters to align to the right of the (.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
        reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to dvcs (f4a9fae)
Loading...