Summary

Fix the DiffCommitIndexView to no longer use hoverIntent

Review Request #7652 — Created Sept. 20, 2015 and submitted Sept. 22, 2015, 1:03 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The hoverIntent jQuery plugin was removed as a dependency on the
release-2.5.x branch and that change was eventually merged into the
dvcs branch. However, the DiffCommitIndexView utilized this plugin.
The view has been reworked to no longer depend on it and a bit of
cleanup has occurred.

Testing Done

Verified that the summaries expanded in the diff viewer.

Issues

Description	From	Last Updated
Can we keep the -s and +s lined up with the other parts of the equation instead of the =?	david	Sept. 22, 2015, 11:39 a.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js

Description:: ~
The hoverIntent jQuery plugin was removed as a dependency on the release-2.5.x branch and that change was eventually merged into the dvcs branch. However, the DiffCommitIndexView utilized this plugin. The view has been reworked to no longer depend on it and a bit of cleanup has occurred.
~
The hoverIntent jQuery plugin was removed as a dependency on the
+ release-2.5.x branch and that change was eventually merged into the
+ dvcs branch. However, the DiffCommitIndexView utilized this plugin.
+ The view has been reworked to no longer depend on it and a bit of
+ cleanup has occurred.

reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js (Diff revision 1)

The issue has been resolved. Show all issues

Can we keep the -s and +s lined up with the other parts of the equation instead of the =?

brennie Sept. 21, 2015, 3:33 p.m.

Ok. I had reindented it to be only 4 spaces in relative to start of line.

david Sept. 21, 2015, 3:35 p.m.

In this case, because it's a continuation that's logically grouped with the stuff to the right of the = sign, I think it makes sense to keep it all to the right of the = sign. This is similar to how we indent other method call parameters to align to the right of the (.

Diff:

Revision 2 (+56 -50)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.js
    reviewboard/static/rb/js/diffviewer/models/diffCommitModel.js

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to dvcs (f4a9fae)

~		The hoverIntent jQuery plugin was removed as a dependency on the `release-2.5.x` branch and that change was eventually merged into the `dvcs` branch. However, the `DiffCommitIndexView` utilized this plugin. The view has been reworked to no longer depend on it and a bit of cleanup has occurred.
	~	The hoverIntent jQuery plugin was removed as a dependency on the
	+	`release-2.5.x` branch and that change was eventually merged into the
	+	`dvcs` branch. However, the `DiffCommitIndexView` utilized this plugin.
	+	The view has been reworked to no longer depend on it and a bit of
	+	cleanup has occurred.