Changed the group reviews header to use the group name

Review Request #7649 — Created Sept. 19, 2015 and submitted

kvdgulik
Review Board
release-2.0.x
reviewboard

Originally, on the dashboard of the group it would say "Review requests for group.name"

It now uses the groups display name in this string instead of group.name. The motivation for this change is that group display names are often more verbose and meaningful.

Tested on Chrome and Firefox to verify that the header displays correctly.

Description From Last Updated

Can you change this to use single quotes?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/views.py
    
    
  2. 
      
brennie
  1. The summary doesn't need to include the bug number. Ideally, it should be in the imperative mood, e.g. "Change the ..."

    Please include testing done (e.g., that you verified that the header was correctly displayed) and a description that describes the problem and its solution

    1. Ping. Just reminding you to finish this so we can land it.

  2. reviewboard/datagrids/views.py (Diff revision 1)
     
     

    Can you change this to use single quotes?

  3. 
      
KV
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/views.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
KV
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ea6bf42)
Loading...