Fix the display of the review request permission denied page.
Review Request #7642 — Created Sept. 18, 2015 and submitted
The template for the review request permission denied page had a bunch of extra
markup that was breaking the box. This fixes it.While I was in here, I noticed that our 403 handler (which should hopefully
never be used) had some TODO text. I've fixed that up too.
Looked at the permission denied page and saw that things looked pretty.
| Description | From | Last Updated |
|---|---|---|
|
This is a little repetitive. How about we change this to help be more informative, with something like: {% if … |
 chipx86
|
|
|
Small typo: "an" should be "and". |
AD adriano | |
|
Mind using blocktrans, so thes can wrap nicely? |
chipx86
|
|
|
Either the <h1> and the opening <p> need to be indented one more space, or the </p> needs to be … |
 mike_conley
|
-
-
reviewboard/templates/403.html (Diff revision 1) This is a little repetitive. How about we change this to help be more informative, with something like:
{% if request.user.is_anonymous %} <p>This may be because you're not logged in. Try logging in an viewing the page again. If you're still seeing this, talk to your administrator.</p> {% else %} <p>This usually means your account hasn't been granted access to this page. If you feel this is in error, talk to your administrator.</p> {% endif %}
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+17 -17) |
-
Tool: Pyflakes Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+17 -17) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html Tool: Pyflakes Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+25 -17) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html Tool: Pyflakes Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html
-
-
reviewboard/templates/reviews/review_request_permission_denied.html (Diff revision 4) Either the <h1> and the opening <p> need to be indented one more space, or the </p> needs to be unindented one. In either case, something's wrong here.
Tool: Pyflakes Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/403.html reviewboard/templates/reviews/review_request_permission_denied.html