On ReviewRequest "Depends On" field, show discarded dependencies with strikethrough

Review Request #7635 — Created Sept. 18, 2015 and submitted

ynkym
Review Board
release-2.0.x
3758
reviewboard

The "Depends On" field on review requests showed submitted
dependencies with strikethrough to indicate it is no longer
relavant, but not for discarded dependencies.

Modified the html rendering for the field to also show
the discarded dependencies with strikethrough.

  • Tested on local dev server.
  • Passes /reviews test
Description From Last Updated

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

In Python, you can do: if item.status in (ReviewRequest.SUBMITTED, ReviewRequest.DISCARDED): Same below.

chipx86chipx86

Not an issue on this line, actually - just a quick issue in your review request Description, but I can't ...

mike_conleymike_conley
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
  2. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  3. reviewboard/reviews/builtin_fields.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (92 > 79 characters)
    
  4. 
      
YN
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
  2. 
      
chipx86
  1. One quick comment about the summary and description:

    We use this information directly, along with the Testing Done, to form the commit message. As such, each line needs to be < 80 characters wide. It's recommended that you compose it in your commit message and set your browser to wrap at 79 characters.

    See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

    It's also crucial that you fill in Testing Done with as much detail as possible about every test you've ran.

  2. 
      
chipx86
  1. Good fix! Small Pythonism you can take advantage of.

  2. reviewboard/reviews/builtin_fields.py (Diff revision 2)
     
     
     

    In Python, you can do:

    if item.status in (ReviewRequest.SUBMITTED,
                       ReviewRequest.DISCARDED):
    

    Same below.

  3. 
      
YN
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/builtin_fields.py
    
    
  2. 
      
YN
mike_conley
  1. 
      
  2. reviewboard/reviews/builtin_fields.py (Diff revision 3)
     
     

    Not an issue on this line, actually - just a quick issue in your review request Description, but I can't open an issue on that.

    "revew" -> "review".

    Otherwise, this looks good to me! Thanks!

  3. 
      
YN
YN
brennie
  1. Can you fix the bug number to 3758?

  2. 
      
YN
YN
YN
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (26fae29)

Loading...