Summary

Add a command to install the extension media of an extension

Review Request #7627 — Created Sept. 13, 2015 and submitted Sept. 13, 2015, 10:16 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

chipx86

Description

Previously, there was no way to install the media of an extension
outside if its intsall procedure. Now there is a management command,
install-extension-media, that will install the extension media of an
extension. This behaviour can be forced (e.g., if the extension is
already installed) with the --force option. Either a single
extension's media will be installed (if --extension-id is provided),
or the extension media of all extensions will be installed.

Testing Done

Installed the extension media for a single extension and all enabled
extensions. Verified --force forces installation.

Issues

Description	From	Last Updated
Col: 9 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Sept. 13, 2015, 7:08 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Sept. 13, 2015, 7:09 p.m.
Col: 13 E303 too many blank lines (2)	reviewbot	Sept. 13, 2015, 7:08 p.m.
Missing a period. Also, should be "ID".	chipx86	Sept. 13, 2015, 10:15 p.m.
Typo. Should be "of".	chipx86	Sept. 13, 2015, 10:14 p.m.

Tool: Pyflakes
Processed Files:
    djblets/extensions/manager.py
    djblets/extensions/management/commands/install-extension-media.py

Ignored Files:
    djblets/extensions/management/commands/__init__.py
    djblets/extensions/management/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/manager.py
    djblets/extensions/management/commands/install-extension-media.py

Ignored Files:
    djblets/extensions/management/commands/__init__.py
    djblets/extensions/management/__init__.py

djblets/extensions/management/commands/install-extension-media.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E123 closing bracket does not match indentation of opening bracket's line
```
djblets/extensions/management/commands/install-extension-media.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/extensions/management/commands/install-extension-media.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E303 too many blank lines (2)
```

Diff:

Revision 2 (+101 -14)

Show changes

	djblets/extensions/manager.py
	djblets/extensions/management/__init__.py
	djblets/extensions/management/commands/__init__.py
	djblets/extensions/management/commands/install-extension-media.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/manager.py
    djblets/extensions/management/commands/install-extension-media.py

Ignored Files:
    djblets/extensions/management/commands/__init__.py
    djblets/extensions/management/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/manager.py
    djblets/extensions/management/commands/install-extension-media.py

Ignored Files:
    djblets/extensions/management/commands/__init__.py
    djblets/extensions/management/__init__.py

Ship it!

Awesome :) Thanks for taking care of this! Two trivial things.

djblets/extensions/management/commands/install-extension-media.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a period. Also, should be "ID".
```
djblets/extensions/manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo. Should be "of".
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (7ebad99)