SVN 1.9 uses (nonexistent) for new files, not (revision 0).

Review Request #7617 — Created Sept. 3, 2015 and submitted

Information

Review Board
master
f57fffe...

Reviewers

Trivial fix: rbt post fails to upload a diff if it includes new files and SVN 1.9 is used.

Tested on 2.0.19 by uploading a diff using svn 1.9; the same patch applies cleanly to master branch.

Description From Last Updated

Can you add regexes for all other translations we use? They should be in the .po files

brenniebrennie

This won't work for German because you have to escape the space in night existent.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
     
     
     
     

    Can you add regexes for all other translations we use? They should be in the .po files

    1. As of revision 1701127, this string has not been localized to any other languages.
      I know about .po files, where do you think I took these translations from? :)

  3. reviewboard/scmtools/svn/__init__.py (Diff revision 1)
     
     

    This won't work for German because you have to escape the space in night existent.

  4. 
      
ST
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/__init__.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
ST
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (8b9cf5a)
Loading...