Summary

SVN 1.9 uses (nonexistent) for new files, not (revision 0).

Review Request #7617 — Created Sept. 3, 2015 and submitted Sept. 9, 2015, 1:38 a.m.

Information

Owner

stilor

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

f57fffe...

Reviewers

Groups

reviewboard

People

Description

Trivial fix: rbt post fails to upload a diff if it includes new files and SVN 1.9 is used.

Testing Done

Tested on 2.0.19 by uploading a diff using svn 1.9; the same patch applies cleanly to master branch.

Issues

Description	From	Last Updated
Can you add regexes for all other translations we use? They should be in the .po files	brennie	Sept. 4, 2015, 1:41 p.m.
This won't work for German because you have to escape the space in night existent.	brennie	Sept. 4, 2015, 1:41 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/svn/__init__.py

reviewboard/scmtools/svn/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

Can you add regexes for all other translations we use? They should be in the .po files

stilor

Sept. 4, 2015, 1:55 p.m.

As of revision 1701127, this string has not been localized to any other languages.
I know about .po files, where do you think I took these translations from? :)

reviewboard/scmtools/svn/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This won't work for German because you have to escape the space in night existent.
```

Change Summary:

Escape whitespace for German, remove trailing | after the last variant (to avoid matching empty string).

Commit:

ed7d57941085a09da5bf75f3934e04baae65618d

f57fffe753cf34ab9064c645d2d67b9477b092e7

Diff:

Revision 2 (+13)

Show changes

reviewboard/scmtools/svn/__init__.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/svn/__init__.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (8b9cf5a)