Summary

Ensure e-mail headers are binary type

Review Request #7612 — Created Aug. 26, 2015 and submitted Aug. 26, 2015, 7:12 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

String literals are unicode by default so including headers from string
literals will result in unicode headers, which will result in unhappy
e-mails. We now ensure that e-mail headers are added to messages as a
binary type.

Unit tests have been updated to be more thorough about checking for
error states.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Rather than this, you probably want to do this in tests: with self.settings(EMAIL_BACKEND=...): ...	chipx86	Aug. 26, 2015, 6:38 p.m.

Tool: Pyflakes
Processed Files:
    djblets/mail/tests.py
    djblets/mail/message.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/mail/tests.py
    djblets/mail/message.py

djblets/mail/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Rather than this, you probably want to do this in tests:

with self.settings(EMAIL_BACKEND=...):
    ...

Diff:

Revision 2 (+32 -2)

Show changes

	djblets/mail/message.py
	djblets/mail/tests.py

Tool: Pyflakes
Processed Files:
    djblets/mail/tests.py
    djblets/mail/message.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/mail/tests.py
    djblets/mail/message.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (d4265fe)