Work around Django form util rename

Review Request #7608 — Created Aug. 25, 2015 and submitted

brennie
Djblets
master
djblets

Django has renamed django.form.util to django.form.utils in 1.7+.
This attempts to import both versions where it is required. The
previous patch that attempted to fix this issue did not update imports
of django.form.util.



Description From Last Updated

'form_utils' imported but unused

reviewbotreviewbot

undefined name 'forms_utils'

reviewbotreviewbot

'form_utils' imported but unused

reviewbotreviewbot

undefined name 'forms_utils'

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/util.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/auth/util.py
    
    
  2. djblets/auth/util.py (Diff revision 1)
     
     
     'form_utils' imported but unused
    
  3. djblets/auth/util.py (Diff revision 1)
     
     
     undefined name 'forms_utils'
    
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/auth/util.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/util.py
    
    
  2. djblets/auth/util.py (Diff revision 2)
     
     
     'form_utils' imported but unused
    
  3. djblets/auth/util.py (Diff revision 2)
     
     
     undefined name 'forms_utils'
    
  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/auth/util.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/util.py
    
    
  2. 
      
chipx86
  1. Can you flesh out the summary/description a bit more? It's nice to have more information about what this change does, independent of the previous one, mentioning the Django 1.7+ compatibility for instance.

  2. 
      
brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (93b3c07)
Loading...