Summary

Work around Django form util rename

Review Request #7608 — Created Aug. 25, 2015 and submitted Aug. 27, 2015, 2:10 a.m.

Information

Owner

brennie

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Django has renamed django.form.util to django.form.utils in 1.7+.

This attempts to import both versions where it is required. The

previous patch that attempted to fix this issue did not update imports

of django.form.util.

Testing Done

Issues

Description	From	Last Updated
'form_utils' imported but unused	reviewbot	Aug. 25, 2015, 8:14 a.m.
undefined name 'forms_utils'	reviewbot	Aug. 25, 2015, 8:14 a.m.
'form_utils' imported but unused	reviewbot	Aug. 25, 2015, 8:15 a.m.
undefined name 'forms_utils'	reviewbot	Aug. 25, 2015, 8:15 a.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/auth/util.py



Tool: Pyflakes
Processed Files:
    djblets/auth/util.py

djblets/auth/util.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'form_utils' imported but unused
```
djblets/auth/util.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'forms_utils'
```

Branch:

release-0.9.x

master

Diff:

Revision 2 (+8 -1)

Show changes

djblets/auth/util.py

Tool: Pyflakes
Processed Files:
    djblets/auth/util.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/auth/util.py

djblets/auth/util.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'form_utils' imported but unused
```
djblets/auth/util.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'forms_utils'
```

Diff:

Revision 3 (+8 -1)

Show changes

djblets/auth/util.py

Tool: Pyflakes
Processed Files:
    djblets/auth/util.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/auth/util.py

Can you flesh out the summary/description a bit more? It's nice to have more information about what this change does, independent of the previous one, mentioning the Django 1.7+ compatibility for instance.

Description:: ~
The previous patch that attempted to fix this issue did not update
~ imports of django.form.util.
~
Django has renamed django.form.util to django.form.utils in 1.7+.
~ This attempts to import both versions where it is required. The
+ previous patch that attempted to fix this issue did not update imports
+ of django.form.util.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (93b3c07)

~		The previous patch that attempted to fix this issue did not update
~		imports of `django.form.util`.
	~	Django has renamed `django.form.util` to `django.form.utils` in 1.7+.
	~	This attempts to import both versions where it is required. The
	+	previous patch that attempted to fix this issue did not update imports
	+	of `django.form.util`.

djblets/auth/util.py (Diff revision 1)

djblets/auth/util.py (Diff revision 1)

djblets/auth/util.py (Diff revision 2)

djblets/auth/util.py (Diff revision 2)