-
-
-
-
reviewboard/reviews/ui/base.py (Diff revision 1) local variable 'result' is assigned to but never used
Consolidate file attachment comment serialization.
Review Request #7605 — Created Aug. 23, 2015 and submitted
We had two places where file attachment comments were being serialized: In ReviewUI, and in a template tag. These were inconsistent and led to problems in text/rich text information, depending on the call site. The template tag now calls out to the review UI for serialization, ensuring we only do this in one place. That serialization has also been updated to store rich text information and to do normalization of the text for edit.
Unit tests pass.
Tested this manually along with another change, and ensured that file
attachment comments always had the correct initial state.
Change Summary:
- Fixed Review Bot complaints.
- Fixed usage when the file attachment isn't rendering first.
- Fixed the serialization format of the comments when using the template tag.
Diff: |
Revision 2 (+20 -31) |
|---|
Tool: Pyflakes Processed Files: reviewboard/reviews/ui/base.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/ui/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/ui/base.py reviewboard/reviews/templatetags/reviewtags.py reviewboard/reviews/ui/tests.py