Summary

Consolidate file attachment comment serialization.

Review Request #7605 — Created Aug. 23, 2015 and submitted Aug. 23, 2015, 10:05 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We had two places where file attachment comments were being serialized:
In ReviewUI, and in a template tag. These were inconsistent and led to
problems in text/rich text information, depending on the call site.

The template tag now calls out to the review UI for serialization,
ensuring we only do this in one place. That serialization has also been
updated to store rich text information and to do normalization of the
text for edit.

Testing Done

Unit tests pass.

Tested this manually along with another change, and ensured that file
attachment comments always had the correct initial state.

Issues

Description	From	Last Updated
'escape' imported but unused	reviewbot	Aug. 23, 2015, 5:52 p.m.
'escape' imported but unused	reviewbot	Aug. 23, 2015, 5:52 p.m.
local variable 'result' is assigned to but never used	reviewbot	Aug. 23, 2015, 6:02 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/ui/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/ui/tests.py

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'escape' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'escape' imported but unused
```
reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'result' is assigned to but never used
```

Change Summary:


Fixed Review Bot complaints.
Fixed usage when the file attachment isn't rendering first.
Fixed the serialization format of the comments when using the template tag.

Diff:

Revision 2 (+20 -31)

Show changes

	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/reviews/ui/base.py
	reviewboard/reviews/ui/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/ui/tests.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/ui/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (5095f1e)