Summary

Allow looking up resources for deferred models

Review Request #7603 — Created Aug. 20, 2015 and submitted Aug. 21, 2015, 12:10 a.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Previously, if you tried to look up the resource for a deferred model,

it would not return a resource. This has been corrected.

Testing Done

Attempted to look up the resource of a deferred model. It worked.

Ran unit tests.

Issues

Description	From	Last Updated
Too many blank lines.	chipx86	Aug. 20, 2015, 11:10 a.m.
Probably should catch here and do the unregister in a finally clause.	chipx86	Aug. 20, 2015, 11:10 a.m.
I'd group these.	chipx86	Aug. 20, 2015, 11:11 a.m.
And these.	chipx86	Aug. 20, 2015, 11:11 a.m.

Tool: Pyflakes
Processed Files:
    djblets/webapi/resources/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources/registry.py

Awesome :) Glad to see this fixed.

Can you throw together a unit test so it doesn't regress if Django does something different?

Summary:: Allow looking up resources for deferrd models
Allow looking up resources for deferred models

Testing Done:

		Attempted to look up the resource of a deferred model. It worked.
	+
	+	Ran unit tests.

Diff:

Revision 2 (+55 -2)

Show changes

	djblets/testing/testcases.py
	djblets/webapi/resources/registry.py
	djblets/webapi/tests/test_registry.py

Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py

Diff:

Revision 3 (+55 -2)

Show changes

	djblets/testing/testcases.py
	djblets/webapi/resources/registry.py
	djblets/webapi/tests/test_registry.py

djblets/webapi/tests/test_registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Too many blank lines.
```
djblets/webapi/tests/test_registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Probably should catch here and do the unregister in a finally clause.
```
djblets/webapi/tests/test_registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
I'd group these.
```
djblets/webapi/tests/test_registry.py (Diff revision 2)
The issue has been resolved. Show all issues
```
And these.
```

Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py

Change Summary:

Address Christian's issues

Diff:

Revision 4 (+53 -2)

Show changes

	djblets/testing/testcases.py
	djblets/webapi/resources/registry.py
	djblets/webapi/tests/test_registry.py

Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py
    djblets/webapi/tests/test_registry.py
    djblets/webapi/resources/registry.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (0457307)