Fix unicode errors when sending notification e-mails.
Review Request #7589 — Created Aug. 14, 2015 and submitted
We already had one place that checked to make sure that we weren't trying to
format un-decoded bytes into a unicode string, but there were a couple other
places where we didn't. I've just copied and pasted the check into all the
relevant places.
Ran unit tests.
-
-
reviewboard/notifications/email.py (Diff revision 1) Let's make a
self._normalize_stringfunction for this, since we shouldn't have to copy/paste, and are likely to just hit this again down the road as we expand our headers.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+14 -6) |
-
Tool: Pyflakes Processed Files: reviewboard/notifications/email.py Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py
-
-
reviewboard/notifications/email.py (Diff revision 2) Should have the new "Args" and "Returns" docstrings.
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+23 -6) |
Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/email.py Tool: Pyflakes Processed Files: reviewboard/notifications/email.py