Summary

Fix unicode errors when sending notification e-mails.

Review Request #7589 — Created Aug. 14, 2015 and submitted Aug. 17, 2015, 1 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3943

Depends On

Commit

485ff0a...

Reviewers

Groups

reviewboard

People

Description

We already had one place that checked to make sure that we weren't trying to
format un-decoded bytes into a unicode string, but there were a couple other
places where we didn't. I've just copied and pasted the check into all the
relevant places.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Let's make a self._normalize_string function for this, since we shouldn't have to copy/paste, and are likely to just hit this …	chipx86	Aug. 14, 2015, 4:37 p.m.
Should have the new "Args" and "Returns" docstrings.	chipx86	Aug. 14, 2015, 4:41 p.m.
Blank line between these.	chipx86	Aug. 14, 2015, 4:41 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py

reviewboard/notifications/email.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's make a self._normalize_string function for this, since we shouldn't have to copy/paste, and are likely to just hit this again down the road as we expand our headers.

Commit:

25955e6412732686f5525cd441431ec1e3c9d3e9

dc8a5cc0854fbffe3812fa4bc58ff5d0d17fcec5

Diff:

Revision 2 (+14 -6)

Show changes

reviewboard/notifications/email.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py

reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should have the new "Args" and "Returns" docstrings.
```
reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Commit:

dc8a5cc0854fbffe3812fa4bc58ff5d0d17fcec5

485ff0a651c4e1c49a8ae230007af0d22609960a

Diff:

Revision 3 (+23 -6)

Show changes

reviewboard/notifications/email.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (027fd15)