• 
      

    Refactor out ready state into a "ReadyView" base class.

    Review Request #7583 — Created Aug. 12, 2015 and submitted

    Information

    student-sonar
    master
    06f7b99...

    Reviewers

    A lot of the views in sonar want to wait until data has been fetched from the
    server to render their contents. This change abstracts out that behavior into a
    base class, so it doesn't have to be reimplemented in subtly different ways all
    over the codebase.

    Tested fresh reloads for all of the changed views.

    Description From Last Updated

    Shouldnt this be _render ?

    brenniebrennie
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          lib/frontend/status-report-editor-view.js
          lib/frontend/all-students-list-view.js
          lib/frontend/my-status-reports-view.js
          lib/frontend/sidebar-view.js
          lib/frontend/calendar-view.js
          lib/frontend/ready-view.js
          lib/frontend/status-report-reading-view.js
          lib/frontend/student-projects-view.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/status-report-editor-view.js
          lib/frontend/all-students-list-view.js
          lib/frontend/my-status-reports-view.js
          lib/frontend/sidebar-view.js
          lib/frontend/calendar-view.js
          lib/frontend/ready-view.js
          lib/frontend/status-report-reading-view.js
          lib/frontend/student-projects-view.js
      
      
    2. 
        
    brennie
    1. 
        
    2. lib/frontend/my-status-reports-view.js (Diff revision 1)
       
       
      Show all issues

      Shouldnt this be _render ?

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (32b3a9e)