Allow Django 1.7 and 1.8

Review Request #7572 — Created Aug. 6, 2015 and submitted

brennie
Djblets
master
djblets

Allow Django 1.7 and 1.8

Running setup.py develop installed Django 1.8.3.

Description From Last Updated

If we allow all versions of 1.8, shouldn't this be <1.9?

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/__init__.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/__init__.py
    
    
  2. 
      
david
  1. 
      
  2. djblets/__init__.py (Diff revision 1)
     
     

    If we allow all versions of 1.8, shouldn't this be <1.9?

    1. The reason for this is to work around the issue of alpha/beta/dev releases. Stephen Gallagher approached us once before with an issue where a version range doing <x.y actually resulted in some compatibility issues, and upon some discussion, we determined the best way to work around Python's version range support issus in this area is to pick a very high .z release for the max range.

      Some of the new version comparison stuff might let us do something a little nicer, but it also depends on the latest-and-greatest versions of setuptools, pip, etc. Using .999 works pretty well, and we're using it already in both Review Board and Djblets for several dependencies.

    2. In that case, I'm dropping this issue.

  3. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0dae867)
Loading...