Tool: Pyflakes Processed Files: rbtools/clients/git.py Tool: PEP8 Style Checker Processed Files: rbtools/clients/git.py
Add git binary support.
Review Request #7571 — Created Aug. 5, 2015 and updated
git diff only contains the difference between binary files when exactly with "--binary" params. When use rbtools to submit path, currently it could not contains binary files. So my patch is to fix this problem.
Can you go into more detail on this change? We require a Description field that clearly states the need/purpose for the change, and a Testing Done that goes into step-by-step detail of how this was tested (Git version(s), prep work, result).
I still don't really understand how this is supposed to improve things. Review Board doesn't know what to do with git binary patches, so at best it will be ignored and at worst it will show an error instead of what it currently does, which is to show "XXX is a binary file"