Summary

Land and patch now properly report errors

Review Request #7568 — Created Aug. 4, 2015 and submitted Aug. 4, 2015, 7:56 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The rbt patch command now always raises a CommandError when it
exits without correctly applying a patch.

The rbt land command now uses correct error checking when calling
into rbt patch to apply patches.

Previously, rbt patch would not report an error via its status code
in some cases and rbt land would then
assume it was successful.

Testing Done

Attempted to land a bad patch and had it fail correctly.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    rbtools/commands/land.py
    rbtools/commands/patch.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/land.py
    rbtools/commands/patch.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1fcbc09)