Summary

ReviewReplyDraftBannerView now properly removed

Review Request #7564 — Created July 31, 2015 and submitted Aug. 5, 2015, 3:22 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Previously the ReviewReplyDraftBannerView was not correctly removed
when a review reply was published; the element would be removed from
the DOM, but the event listeners would still fire (and cause errors in
the console). Now, the view is correctly removed with
Backbone.View.remove so the elements are removed from the DOM and all
event listeners are disconnects.

Testing Done

Ran JS tests.

With this patch applied, the error no longer appears in the console.

Issues

Description	From	Last Updated
Did you mean to call this this._banner, or use this._bannerView below?	david	Aug. 4, 2015, 8:46 a.m.
Typo: "SHown"	david	Aug. 4, 2015, 8:45 a.m.
This should be this._bannerView, right?	david	Aug. 4, 2015, 7:53 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js

reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Did you mean to call this this._banner, or use this._bannerView below?
```
reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: "SHown"
```

Diff:

Revision 2 (+9 -5)

Show changes

reviewboard/static/rb/js/views/reviewBoxView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js

reviewboard/static/rb/js/views/reviewBoxView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be this._bannerView, right?
```

Diff:

Revision 3 (+9 -5)

Show changes

reviewboard/static/rb/js/views/reviewBoxView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/reviewBoxView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (cac7f06)