ReviewReplyDraftBannerView now properly removed

Review Request #7564 — Created July 31, 2015 and submitted

brennie
Review Board
release-2.5.x
reviewboard

Previously the ReviewReplyDraftBannerView was not correctly removed
when a review reply was published; the element would be removed from
the DOM, but the event listeners would still fire (and cause errors in
the console). Now, the view is correctly removed with
Backbone.View.remove so the elements are removed from the DOM and all
event listeners are disconnects.

Ran JS tests.

With this patch applied, the error no longer appears in the console.

Description From Last Updated

Did you mean to call this this._banner, or use this._bannerView below?

daviddavid

Typo: "SHown"

daviddavid

This should be this._bannerView, right?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
  2. 
      
david
  1. 
      
  2. Did you mean to call this this._banner, or use this._bannerView below?

  3. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
  2. 
      
david
  1. 
      
  2. This should be this._bannerView, right?

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewBoxView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (cac7f06)
Loading...