ReviewReplyDraftBannerView now properly removed
Review Request #7564 — Created July 31, 2015 and submitted
Previously the
ReviewReplyDraftBannerView
was not correctly removed
when a review reply was published; the element would be removed from
the DOM, but the event listeners would still fire (and cause errors in
the console). Now, the view is correctly removed with
Backbone.View.remove
so the elements are removed from the DOM and all
event listeners are disconnects.
Ran JS tests.
With this patch applied, the error no longer appears in the console.
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/reviewBoxView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/reviewBoxView.js