brennie got a fish trophy!

Summary

Send "Ship It!" e-mail headers

Review Request #7557 — Created July 28, 2015 and submitted July 29, 2015, 12:51 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

~~7556~~

Reviewers

Groups

reviewboard

People

Description

Review Board now sends special headers along with review e-mails
indicating if a review contains a "Ship It!" (in which case it will
contain the X-ReviewBoard-ShipIt header) or if it only contains a
"Ship It!" it (in which case both the X-ReviewBoard-ShipIt and
X-ReviewBoard-ShipIt-Only headers will be sent).

Test cases have been added that cover all possible review scenarios.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 28, 2015, 7:22 p.m.
You can do assertIn and assertNotIn for these sorts of tests. (These came after the implementation of the older tests …	chipx86	July 29, 2015, 12:37 p.m.
We should also support the case of Ship It with no body text at all (such as going into the …	chipx86	July 29, 2015, 12:40 p.m.
Let's specifically say diff comments.	chipx86	July 29, 2015, 12:41 p.m.
"Return"	chipx86	July 29, 2015, 12:41 p.m.
As per above, let's support either SHIP_IT_TEXT or an empty body.	chipx86	July 29, 2015, 12:40 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/models/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Depends On:: ~~7556 - Allow sending extra headers with e-mails~~

Change Summary:

PEP8

Diff:

Revision 2 (+166 -2)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/testing/testcase.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py

Diff:

Revision 3 (+167 -2)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/testing/testcase.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py

reviewboard/notifications/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

You can do assertIn and assertNotIn for these sorts of tests. (These came after the implementation of the older tests in here.)

reviewboard/notifications/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

We should also support the case of Ship It with no body text at all (such as going into the review dialog, clicking Ship It, and publishing).

reviewboard/notifications/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Let's specifically say diff comments.
```
reviewboard/reviews/models/review.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"Return"
```
reviewboard/reviews/models/review.py (Diff revision 3)
The issue has been resolved. Show all issues
```
As per above, let's support either SHIP_IT_TEXT or an empty body.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (4db9fa3)

Status:: Re-opened

Change Summary:

Address Christian's issues.

Description:

		Review Board now sends special headers along with review e-mails
		indicating if a review contains a "Ship It!" (in which case it will
		contain the `X-ReviewBoard-ShipIt` header) or if it only contains a
		"Ship It!" it (in which case both the `X-ReviewBoard-ShipIt` and
~		`X-ReviewBoard-ShipIt-Only` headers will be sent.
	~	`X-ReviewBoard-ShipIt-Only` headers will be sent).

		Test cases have been added that cover all possible review scenarios.

Diff:

Revision 4 (+188 -4)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/testing/testcase.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/reviews/models/review.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (307e929)