-
-
reviewboard/reviews/models/review.py (Diff revision 1) Col: 80 E501 line too long (80 > 79 characters)
brennie got a fish trophy!
Send "Ship It!" e-mail headers
Review Request #7557 — Created July 28, 2015 and submitted
Review Board now sends special headers along with review e-mails
indicating if a review contains a "Ship It!" (in which case it will
contain theX-ReviewBoard-ShipItheader) or if it only contains a
"Ship It!" it (in which case both theX-ReviewBoard-ShipItand
X-ReviewBoard-ShipIt-Onlyheaders will be sent).Test cases have been added that cover all possible review scenarios.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 80 E501 line too long (80 > 79 characters) |
 reviewbot
|
|
|
You can do assertIn and assertNotIn for these sorts of tests. (These came after the implementation of the older tests … |
 chipx86
|
|
|
We should also support the case of Ship It with no body text at all (such as going into the … |
chipx86
|
|
|
Let's specifically say diff comments. |
chipx86
|
|
|
"Return" |
chipx86
|
|
|
As per above, let's support either SHIP_IT_TEXT or an empty body. |
chipx86
|
-
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py
-
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py
-
-
reviewboard/notifications/tests.py (Diff revision 3) You can do
assertInandassertNotInfor these sorts of tests. (These came after the implementation of the older tests in here.) -
reviewboard/notifications/tests.py (Diff revision 3) We should also support the case of Ship It with no body text at all (such as going into the review dialog, clicking Ship It, and publishing).
-
-
-
reviewboard/reviews/models/review.py (Diff revision 3) As per above, let's support either SHIP_IT_TEXT or an empty body.
Change Summary:
Address Christian's issues.
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+188 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py
Tool: Pyflakes Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/testcase.py reviewboard/notifications/email.py reviewboard/notifications/tests.py reviewboard/reviews/models/review.py