Fix event handling for clicking on user sidebar entries.

Review Request #7551 — Created July 28, 2015 and submitted

Information

student-sonar
master
b5581d1...

Reviewers

For the sidebar, the event handling was using ev.target, which in the case of
clicking directly on a name (rather than next to it) would be the <span>
element rather than the <a>. Changing to ev.currentTarget fixes this.

Clicked around and saw that user links always worked no matter which part of
the sidebar entry I clicked on.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        lib/frontend/sidebar-view.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        lib/frontend/sidebar-view.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (8376c4a)
Loading...