Implement "Manage" mode for the user detail view.

Review Request #7549 — Created July 27, 2015 and submitted

Information

student-sonar
master
c9d521a...

Reviewers

This change adds admin facilities for the user detail view that allow setting
certain details (like the RB Username), as well as editing the lists of links
(like projects, demo videos, etc.).

  • Saw that everything toggled correctly when turning on manage mode.
  • Edited groups, rb username, school, e-mail address, and links.
  • Tested cancellation of different editors.

Description From Last Updated

Is there a horizontal line going through there?

brenniebrennie

The popout "<" doesn't have a shadow but the rest of the box does. Is it possible to put a …

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        package.json
        lib/frontend/config.js
        lib/frontend/user-detail-view.js
        lib/frontend/main.js
        lib/frontend/calendar-view.js
        css/style.less
        views/layouts/main.handlebars
        lib/frontend/models.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        package.json
        lib/frontend/config.js
        lib/frontend/user-detail-view.js
        lib/frontend/main.js
        lib/frontend/calendar-view.js
        css/style.less
        views/layouts/main.handlebars
        lib/frontend/models.js
    
    
  2. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        package.json
        lib/frontend/config.js
        lib/frontend/user-detail-view.js
        lib/frontend/main.js
        lib/frontend/calendar-view.js
        css/style.less
        views/layouts/main.handlebars
        lib/frontend/models.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        package.json
        lib/frontend/config.js
        lib/frontend/user-detail-view.js
        lib/frontend/main.js
        lib/frontend/calendar-view.js
        css/style.less
        views/layouts/main.handlebars
        lib/frontend/models.js
    
    
  2. 
      
brennie
  1. 
      
  2. Show all issues

    Is there a horizontal line going through there?

    1. That seems to be an artifact of the screenshot mechanism.

  3. Show all issues

    The popout "<" doesn't have a shadow but the rest of the box does. Is it possible to put a shadow on it?

    1. This is just using bootstrap's callouts, so I dunno. Given that this is preliminary, admin-only UI I'm not too concerned about it right now.

  4. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (f4db716)
Loading...