Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/reviews/reviewable_page_data.js Tool: Pyflakes Ignored Files: reviewboard/templates/reviews/reviewable_page_data.js
Fix filename caption rendering
Review Request #7538 — Created July 24, 2015 and submitted
Previously, captions were escaped twice: once with
reviewable_page_data.jstemplate and again via the underscore template
RB.FileAttachmentThumbnail. Since the only place a
RB.FileAttachmentModelwill retrieve an escaped value for the caption
is from the JS template, we unescape it there so that the model recieves
the correct value.
The filename is now also correctly parsed.
Ran JS tests.
Verified that a caption with unsafe characters was correctly set in
both the JS model and the database model.