Fix filename caption rendering

Review Request #7538 — Created July 24, 2015 and submitted

brennie
Review Board
release-2.5.x
reviewboard

Previously, captions were escaped twice: once with escapejs in the
reviewable_page_data.js template and again via the underscore template
in the RB.FileAttachmentThumbnail. Since the only place a
RB.FileAttachmentModel will retrieve an escaped value for the caption
is from the JS template, we unescape it there so that the model recieves
the correct value.

The filename is now also correctly parsed.

Ran JS tests.

Verified that a caption with unsafe characters was correctly set in
both the JS model and the database model.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (d012f99)
Loading...