Allow 'rbt' to bypass external authentication (RB site might have SSO auth) with prepared extra auth. cookies file.

Review Request #7531 — Created July 17, 2015 and submitted

Information

RBTools

Reviewers

Add --ext-auth-cookies to allow
'rbt' to bypass external authentication (RB site might have SSO auth) with prepared cookies file.

[vsafronov@vm-el6 xxx-utilities]$ sh myrbt.sh
Review request #9645 posted.

http://rb.xxx.com/rb/r/9645/
http://rb.xxx.com/rb/r/9645/diff/

[vsafronov@vm-el6 xxx-utilities]$ cat myrbt.sh 
#!/bin/sh

rbt post --server http://rb.xxx.com/rb --ext-auth-cookies ~/my_sso_cookies.txt -g --repository 'xxx Utilities (git)' --tracking-branch master --branch master HEAD~ HEAD
Description From Last Updated

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 80 E501 line too long (82 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (91 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (96 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (100 > 79 characters)

reviewbotreviewbot

Col: 42 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 33 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Add added_in parameter.

gmyersgmyers

ReviewBoard should be two words.

gmyersgmyers

The capitalization of "Single sign-On" here is weird.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  3. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  4. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  5. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  6. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (82 > 79 characters)
    
  7. rbtools/api/request.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (91 > 79 characters)
    
  8. rbtools/commands/__init__.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (96 > 79 characters)
    
  9. rbtools/commands/__init__.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (100 > 79 characters)
    
  10. 
      
VA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. rbtools/api/request.py (Diff revision 2)
     
     
    Show all issues
    Col: 42
     W291 trailing whitespace
    
  3. rbtools/commands/__init__.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  4. 
      
VA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. rbtools/commands/__init__.py (Diff revision 3)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  3. 
      
david
  1. Can you mark Review Bot's issues as fixed or dropped as you address them? That way we'll know when this is ready to look at. Thanks!

    1. Hi David, all issues have been fixed (and set dropped). /v

  2. 
      
VA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. rbtools/api/request.py (Diff revision 4)
     
     
    Show all issues
    Col: 33
     E128 continuation line under-indented for visual indent
    
  3. 
      
VA
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/commands/__init__.py (Diff revision 5)
     
     
    Show all issues

    The capitalization of "Single sign-On" here is weird.

    1. Hi David!

      Any chance to get this patch approved?

  3. 
      
gmyers
  1. 
      
  2. rbtools/commands/__init__.py (Diff revision 5)
     
     
     
     
    Show all issues

    Add added_in parameter.

    1. fixed: added_in='0.7.5'

  3. rbtools/commands/__init__.py (Diff revision 5)
     
     
    Show all issues
    ReviewBoard should be two words.
  4. 
      
VA
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/api/transport/sync.py
        rbtools/api/request.py
        rbtools/commands/__init__.py
    
    
    1. curious why I have no single email notice on this review request..

    2. Hi All! Do I have any chance to have my patch shipped?

    3. We've been having some trouble with e-mail delivery on reviews.reviewboard.org -- we're currently working on the problem. I'll take a look at this now.

  2. 
      
david
  1. Ship It!
  2. 
      
VA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (5985bfc)