Summary

Allow 'rbt' to bypass external authentication (RB site might have SSO auth) with prepared extra auth. cookies file.

Review Request #7531 — Created July 17, 2015 and submitted Aug. 14, 2015, 3:26 p.m.

Information

Owner

Valdis

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Add --ext-auth-cookies to allow
'rbt' to bypass external authentication (RB site might have SSO auth) with prepared cookies file.

Testing Done

[vsafronov@vm-el6 xxx-utilities]$ sh myrbt.sh
Review request #9645 posted.

http://rb.xxx.com/rb/r/9645/
http://rb.xxx.com/rb/r/9645/diff/

[vsafronov@vm-el6 xxx-utilities]$ cat myrbt.sh 
#!/bin/sh

rbt post --server http://rb.xxx.com/rb --ext-auth-cookies ~/my_sso_cookies.txt -g --repository 'xxx Utilities (git)' --tracking-branch master --branch master HEAD~ HEAD

Issues

Description	From	Last Updated
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	July 17, 2015, 7:57 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	July 17, 2015, 7:57 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	July 17, 2015, 7:57 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	July 20, 2015, 8:26 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	July 20, 2015, 8:26 a.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	July 20, 2015, 8:26 a.m.
Col: 80 E501 line too long (96 > 79 characters)	reviewbot	July 20, 2015, 8:26 a.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	July 20, 2015, 8:27 a.m.
Col: 42 W291 trailing whitespace	reviewbot	July 20, 2015, 8:27 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 20, 2015, 8:27 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	July 17, 2015, 8:19 a.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	July 20, 2015, 8:28 a.m.
Add added_in parameter.	gmyers	July 28, 2015, 4:44 a.m.
ReviewBoard should be two words.	gmyers	July 28, 2015, 4:44 a.m.
The capitalization of "Single sign-On" here is weird.	david	July 28, 2015, 4:44 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/api/request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/api/request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
rbtools/api/request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
rbtools/api/request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (96 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```

Change Summary:

fixed Review Bot issues.

Diff:

Revision 2 (+26 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

rbtools/api/request.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 42
 W291 trailing whitespace
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Change Summary:

Review Bot fixes

Diff:

Revision 3 (+26 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

rbtools/commands/__init__.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Can you mark Review Bot's issues as fixed or dropped as you address them? That way we'll know when this is ready to look at. Thanks!

Valdis July 20, 2015, 8:31 a.m.

Hi David, all issues have been fixed (and set dropped). /v

Change Summary:

remove unnecessary code

Diff:

Revision 4 (+24 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

rbtools/api/request.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

Change Summary:

indent fix

Diff:

Revision 5 (+24 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

rbtools/commands/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
The capitalization of "Single sign-On" here is weird.
```
1. VA
  
  Valdis Aug. 10, 2015, 10:56 a.m.
  Hi David!
  
  Any chance to get this patch approved?

rbtools/commands/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Add added_in parameter.
```
1. VA
  
  Valdis July 28, 2015, 4:56 a.m.
  fixed: added_in='0.7.5'
rbtools/commands/__init__.py (Diff revision 5)
The issue has been resolved. Show all issues
```
ReviewBoard should be two words.
```

Change Summary:

three issues fixed.

Diff:

Revision 6 (+25 -4)

Show changes

	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py



Tool: Pyflakes
Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/request.py
    rbtools/commands/__init__.py

Valdis July 28, 2015, 6:43 a.m.

curious why I have no single email notice on this review request..

Valdis Aug. 10, 2015, 1:22 a.m.

Hi All! Do I have any chance to have my patch shipped?

david Aug. 14, 2015, 3:23 p.m.

We've been having some trouble with e-mail delivery on reviews.reviewboard.org -- we're currently working on the problem. I'll take a look at this now.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (5985bfc)

rbtools/api/request.py (Diff revision 1)

rbtools/api/request.py (Diff revision 1)

rbtools/api/request.py (Diff revision 1)

rbtools/api/request.py (Diff revision 1)