Summary

Fix posting Perforce paths that are not included in the client view.

Review Request #7520 — Created July 13, 2015 and submitted July 14, 2015, 12:32 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.7.x

Bugs

3864

Depends On

Reviewers

Groups

rbtools

People

Description

The code that checked files for include/exclude regressed the case where the
user wanted to do a post-commit review using perforce paths and the paths were
not present in the client view. This change fixes that up to cope with p4 where
returning an error.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Blank line between these.	chipx86	July 14, 2015, 12:21 p.m.
Blank line between these.	chipx86	July 14, 2015, 12:21 p.m.
This was a problem before, but this is indented too far.	chipx86	July 14, 2015, 12:22 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This was a problem before, but this is indented too far.
```

Diff:

Revision 2 (+11 -4)

Show changes

rbtools/clients/perforce.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (38a857c)

rbtools/clients/perforce.py (Diff revision 1)

rbtools/clients/perforce.py (Diff revision 1)

rbtools/clients/perforce.py (Diff revision 1)