Fix posting Perforce paths that are not included in the client view.

Review Request #7520 — Created July 13, 2015 and submitted

Information

RBTools
release-0.7.x

Reviewers

The code that checked files for include/exclude regressed the case where the
user wanted to do a post-commit review using perforce paths and the paths were
not present in the client view. This change fixes that up to cope with p4 where
returning an error.

Ran unit tests.

Description From Last Updated

Blank line between these.

chipx86chipx86

Blank line between these.

chipx86chipx86

This was a problem before, but this is indented too far.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Blank line between these.

  3. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Blank line between these.

  4. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    This was a problem before, but this is indented too far.

  5. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (38a857c)