Fix mobile datagrid header on Firefox
Review Request #7518 — Created July 13, 2015 and submitted
This patch removes some CSS rules that make the datagrid header show a
white background in Firefox. Firefox interpretsvisibility: nonewith
a background colour set to not show the background colour. Removing
these rules does not affect otherwise affect rendering.
I viewed the Review Board dashboard, all review requests page, and
users page review requests and reviews grids on the following browsers:
- Chrome desktop
- Chrome desktop (mobile mode)
- Chrome for Android
- Firefox desktop
- Firefox desktop (mobile mode)
- Firefox for Android
- Safari desktop
- Safari desktop (mobile mode)
-
Can you confirm this was tested with the dashboard, All Review Requests page, and a user's Review Requests and Reviews grids on the user page, in both mobile and non-mobile on Chrome and Firefox?
Review request changed
- Testing Done:
-
~ Viewed the mobile mode header in Chrome, Firefox, Safari. I also viewed
~ the page on Firefox for Android and Chrome for Android. ~ I viewed the Review Board dashboard, all review requests page, and
~ users page review requests and reviews grids on the following browsers: + + - Chrome desktop
+ - Chrome desktop (mobile mode)
+ - Chrome for Android
+ - Firefox desktop
+ - Firefox desktop (mobile mode)
+ - Firefox for Android
+ - Safari desktop
+ - Safari desktop (mobile mode)
Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/css/datagrid.less Tool: Pyflakes Ignored Files: djblets/static/djblets/css/datagrid.less