The select columns menu now slides in and out.

Review Request #7517 — Created July 13, 2015 and submitted

Information

Djblets
release-0.9.x

Reviewers

The select columns menu now uses a jQuery animation to slide in and out
instead of merely appearing and disappearing. This also fixes a bug
where the menu would display off by one pixel in Firefox.

Saw that the menu slid in/out correctly in Firefox, Chrome, and Safari.


Description From Last Updated

innerHeight() will get you the full height minus the border.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
  2. 
      
chipx86
  1. 
      
  2. djblets/static/djblets/js/datagrid.js (Diff revision 3)
     
     
     
    Show all issues

    innerHeight() will get you the full height minus the border.

  3. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (3d558b1)
Loading...