The select columns menu now slides in and out.
Review Request #7517 — Created July 13, 2015 and submitted
The select columns menu now uses a jQuery animation to slide in and out
instead of merely appearing and disappearing. This also fixes a bug
where the menu would display off by one pixel in Firefox.
Saw that the menu slid in/out correctly in Firefox, Chrome, and Safari.
| Description | From | Last Updated |
|---|---|---|
|
innerHeight() will get you the full height minus the border. |
 chipx86
|
- Description:
-
The select columns menu now uses a jQuery animation to slide in and out
~ instead of merely appearing and disappearing. ~ instead of merely appearing and disappearing. This also fixes a bug + where the menu would display off by one pixel in Firefox. - Testing Done:
-
~ Saw that the menu slid in/out correctly.
~ Saw that the menu slid in/out correctly in Firefox, Chrome, and Safari.
- Diff:
-
Revision 2 (+20 -4)
-
Tool: Pyflakes Ignored Files: djblets/static/djblets/js/datagrid.js Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/datagrid.js
-
Tool: Pyflakes Ignored Files: djblets/static/djblets/js/datagrid.js Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/datagrid.js
Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/datagrid.js Tool: Pyflakes Ignored Files: djblets/static/djblets/js/datagrid.js