Summary

Add X-ReviewBoard-Diff-For header in E-Mails

Review Request #7509 — Created July 9, 2015 and submitted July 11, 2015, 3:55 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

9c3ed1b...

Reviewers

Groups

reviewboard

People

Description

E-Mails sent by Review Board now add a X-ReviewBoard-Diff-For header

for each file that was modified in the diff. In the case of a moved or

copied file, both the source and destination file names are added.

Otherwise only the relevant file names (source in the case of deleted

and destination in the case of new) are added.
To facilitate this change, our SpiffyEmailMessage class has been

overhauled to handle message headers. Django expects the headers to be

a plain dict, but since we are repeating headers we now use a

MultiValueDict. All E-Mail unit tests have been updated to look for

headers in the correct location and new unit tests have been added to

test the X-ReviewBoard-Diff-For header.

Testing Done

Unit tests pass.

Published a review request with multiple files modified. Saw multiple
X-ReviewBoard-Diff-For headers in the resulting E-Mail mesage.

Issues

Description	From	Last Updated
Swap these.	chipx86	July 9, 2015, 1:14 p.m.
redefinition of unused 'test_review_request_email_with_moved_file' from line 608	reviewbot	July 9, 2015, 1:08 p.m.
Col: 13 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	July 9, 2015, 1:08 p.m.
Col: 1 W391 blank line at end of file	reviewbot	July 9, 2015, 1:08 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'test_review_request_email_with_moved_file' from line 608
```
reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/notifications/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Commit:

-	efe5213ce0b648302a74fc0de6f60602882a0c07
+	08d9bac1a5e478589afa44b07f3b1d1d25043516

Diff:

Revision 2 (+199 -26)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Wow, awesome job. You just plowed through that.

Other than Review Bot's complaints, I only have one issue, which is trivial.

brennie July 9, 2015, 1:14 p.m.
```
:)
```

reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these.
```

Commit:

-	08d9bac1a5e478589afa44b07f3b1d1d25043516
+	9c3ed1b676d1540c568d745dab253d2bfa69b1c9

Diff:

Revision 3 (+199 -26)

Show changes

	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (7cf3e24)