Fix plumbing of change number when using --diff-filename.
Review Request #7501 — Created July 7, 2015 and submitted
A previous change of mine fixed an exception when trying to use
--diff-filename, but didn't fix an issue where we had regressed the use of
this command-line argument with systems that use change numbers (such as
perforce). This change fixes the plumbing so that we set the change number
correctly even if the user (for some reason) is choosing the create the diff
themselves.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Can you add Args and Returns sections to the docstring? Same with the one in Perforce. |
 chipx86
|
|
|
"when" |
chipx86
|
|
|
This bit about what we'd ideally do is probably best suited for a comment and not any public-facing docs. |
chipx86
|
|
|
Do we want to use six for this? |
chipx86
|
|
|
Use self.REVISION_DEFAULT_CLN rather than literal 'default'. |
 gmyers
|
-
-
rbtools/clients/__init__.py (Diff revision 1) Can you add
ArgsandReturnssections to the docstring? Same with the one in Perforce. -
-
rbtools/clients/perforce.py (Diff revision 1) This bit about what we'd ideally do is probably best suited for a comment and not any public-facing docs.
-
-
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/clients/__init__.py rbtools/clients/perforce.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/clients/__init__.py rbtools/clients/perforce.py
-
-
rbtools/clients/perforce.py (Diff revision 2) Use
self.REVISION_DEFAULT_CLNrather than literal 'default'.
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/clients/__init__.py rbtools/clients/perforce.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/clients/__init__.py rbtools/clients/perforce.py