Summary

Update to use more of Djblets's new API and testing support.

Review Request #7499 — Created July 7, 2015 and submitted July 16, 2015, 3:57 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

9d7d7fd...

Reviewers

Groups

reviewboard

People

Description

More of Review Board's code has moved into Djblets in recent changes,
which allows us to remove a lot of code from Review Board. This impacts
the API resources and the unit testing code.

It also removes a redundant call to initialize() in the base API
testcase, which is already called in the base Review Board testcase.

Testing Done

All unit tests pass.

Issues

Description	From	Last Updated
'copy' imported but unused	reviewbot	July 12, 2015, 12:56 a.m.
'sys' imported but unused	reviewbot	July 12, 2015, 12:56 a.m.
'serializers' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'IntegrityError' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'connections' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'DEFAULT_DB_ALIAS' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'DatabaseError' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'router' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'get_apps' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'Q' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.
'initialize' imported but unused	reviewbot	July 12, 2015, 12:57 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'copy' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'sys' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'serializers' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'IntegrityError' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'connections' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'DEFAULT_DB_ALIAS' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'DatabaseError' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'router' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_apps' imported but unused
```
reviewboard/webapi/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Q' imported but unused
```
reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'initialize' imported but unused
```

Change Summary:

Fixed all the unused imports.

Commit:

-	f2dcadfb8fb936a6c9ac777c8f9eda71fcfc0d89
+	9d7d7fde29c69273914fc928a684400e45c14fbc

Diff:

Revision 2 (+31 -222)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/base.py
	reviewboard/webapi/tests/base.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (11fc8bc)

reviewboard/webapi/base.py (Diff revision 1)