This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-2.5.x (11fc8bc)

Summary

Update to use more of Djblets's new API and testing support.

Review Request #7499 — Created July 7, 2015 and submitted 9 years, 11 months ago

Information

Owner

chipx86*

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

9d7d7fd...

Reviewers

Groups

reviewboard

People

Description*

More of Review Board's code has moved into Djblets in recent changes,
which allows us to remove a lot of code from Review Board. This impacts
the API resources and the unit testing code.

It also removes a redundant call to initialize() in the base API
testcase, which is already called in the base Review Board testcase.

Testing Done

All unit tests pass.

Issues

Description	From	Last Updated
'copy' imported but unused	reviewbot	9 years, 11 months ago
'sys' imported but unused	reviewbot	9 years, 11 months ago
'serializers' imported but unused	reviewbot	9 years, 11 months ago
'IntegrityError' imported but unused	reviewbot	9 years, 11 months ago
'connections' imported but unused	reviewbot	9 years, 11 months ago
'DEFAULT_DB_ALIAS' imported but unused	reviewbot	9 years, 11 months ago
'DatabaseError' imported but unused	reviewbot	9 years, 11 months ago
'router' imported but unused	reviewbot	9 years, 11 months ago
'get_apps' imported but unused	reviewbot	9 years, 11 months ago
'Q' imported but unused	reviewbot	9 years, 11 months ago
'initialize' imported but unused	reviewbot	9 years, 11 months ago
There are no open issues

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'copy' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'sys' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'serializers' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'IntegrityError' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'connections' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'DEFAULT_DB_ALIAS' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'DatabaseError' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'router' imported but unused
```
reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_apps' imported but unused
```
reviewboard/webapi/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Q' imported but unused
```
reviewboard/webapi/tests/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'initialize' imported but unused
```

Change Summary:

Fixed all the unused imports.

Commit:

f2dcadfb8fb936a6c9ac777c8f9eda71fcfc0d89

9d7d7fde29c69273914fc928a684400e45c14fbc

Diff:

Revision 2 (+31 -222)

Show changes

	reviewboard/testing/testcase.py
	reviewboard/webapi/base.py
	reviewboard/webapi/tests/base.py

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/base.py
    reviewboard/webapi/tests/base.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (11fc8bc)

reviewboard/webapi/base.py (Diff revision 1)