Update to use more of Djblets's new API and testing support.

Review Request #7499 — Created July 7, 2015 and submitted

Information

Review Board
release-2.5.x
9d7d7fd...

Reviewers

More of Review Board's code has moved into Djblets in recent changes,
which allows us to remove a lot of code from Review Board. This impacts
the API resources and the unit testing code.

It also removes a redundant call to initialize() in the base API
testcase, which is already called in the base Review Board testcase.

All unit tests pass.

Description From Last Updated

'copy' imported but unused

reviewbotreviewbot

'sys' imported but unused

reviewbotreviewbot

'serializers' imported but unused

reviewbotreviewbot

'IntegrityError' imported but unused

reviewbotreviewbot

'connections' imported but unused

reviewbotreviewbot

'DEFAULT_DB_ALIAS' imported but unused

reviewbotreviewbot

'DatabaseError' imported but unused

reviewbotreviewbot

'router' imported but unused

reviewbotreviewbot

'get_apps' imported but unused

reviewbotreviewbot

'Q' imported but unused

reviewbotreviewbot

'initialize' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/base.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/base.py
    
    
  2. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'copy' imported but unused
    
  3. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'sys' imported but unused
    
  4. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'serializers' imported but unused
    
  5. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'IntegrityError' imported but unused
    
  6. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'connections' imported but unused
    
  7. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'DEFAULT_DB_ALIAS' imported but unused
    
  8. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'DatabaseError' imported but unused
    
  9. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'router' imported but unused
    
  10. reviewboard/testing/testcase.py (Diff revision 1)
     
     
    Show all issues
     'get_apps' imported but unused
    
  11. reviewboard/webapi/base.py (Diff revision 1)
     
     
    Show all issues
     'Q' imported but unused
    
  12. reviewboard/webapi/tests/base.py (Diff revision 1)
     
     
    Show all issues
     'initialize' imported but unused
    
  13. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/base.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/base.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (11fc8bc)