Summary

Do not render links in checkbox columns

Review Request #7487 — Created July 3, 2015 and submitted July 13, 2015, 12:46 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

0078e83...

Reviewers

Groups

djblets

People

Description

Cell rendering in DataGrid columns has been updated to allow the cell
to override the DataGrid's choice of cell template. This allows the
the CheckboxColumn to render without links, which would previously
activate when checked.

Testing Done

Tested the change with Review Board. There were no links in the
dashboard's checkboxes. Checking the checkbox did not redirect before
and after switching into mobile mode.

Issues

Description	From	Last Updated
local variable 'datagrid' is assigned to but never used	reviewbot	July 3, 2015, 7:23 p.m.
This is pretty lengthy, in terms of line count. Can you format like: state.blah = \ self.renderblah(...)	chipx86	July 4, 2015, 12:41 a.m.
Careful. The render context should be shared amongst all cells, as an optimization (with a standard RequestContext, it'd rebuild bits …	chipx86	July 4, 2015, 12:41 a.m.

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py

djblets/datagrid/grids.py (Diff revision 1)

Show all issues

 local variable 'datagrid' is assigned to but never used

Change Summary:

PEP8

Commit:

-	9cc0fcba57a201f6e2bbcac7c9cb229188a81ffd
+	a5659a69999877aa8f3b95226513629a71133894

Diff:

Revision 2 (+48 -4)

Show changes

djblets/datagrid/grids.py

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py

djblets/datagrid/grids.py (Diff revision 2)

Show all issues

This is pretty lengthy, in terms of line count. Can you format like:

state.blah = \
    self.renderblah(...)

djblets/datagrid/grids.py (Diff revision 2)

Show all issues

Careful. The render context should be shared amongst all cells, as an optimization (with a standard RequestContext, it'd rebuild bits for every cell, which was slow).

Maybe instead of all this, we just change the template for those cells?

Description:

~		Cell rendering in columns has been refactored to allow the column class
~		to override a the method by which the cached cell will be generated.
~		This allows subclasses to specialize cell rendering by e.g., injecting
~		extra context. This has been used to ensure that the `url` context
	~	Cell rendering in DataGrid columns has been updated to allow the cell
	~	to override the `DataGrid`'s choice of cell template. This allows the
	~	the `CheckboxColumn` to render without links, which would previously
	~	activate when checked.
-		parameter is never set when rendering a `CheckboxColumn` so that links
-		will not appear in the column. Previously, a link would be rendered if
-		there was a URL set for the row and checking the checkbox would
-		activate the link.

Testing Done:

		Tested the change with Review Board. There were no links in the
~		dashboard's checkboxes.
	~	dashboard's checkboxes. Checking the checkbox did not redirect before
	+	and after switching into mobile mode.

Commit:

-	a5659a69999877aa8f3b95226513629a71133894
+	0078e83404e4522dd318efed67e0dbd330737770

Diff:

Revision 3 (+25 -4)

Show changes

	djblets/datagrid/grids.py
	djblets/datagrid/templates/datagrid/cell_no_link.html

Tool: Pyflakes
Processed Files:
    djblets/datagrid/grids.py

Ignored Files:
    djblets/datagrid/templates/datagrid/cell_no_link.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/datagrid/grids.py

Ignored Files:
    djblets/datagrid/templates/datagrid/cell_no_link.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (3381f1d)