• 
      

    More refactoring.

    Review Request #7484 — Created July 3, 2015 and discarded

    Information

    student-sonar
    master

    Reviewers

    This change accomplishes several things:
    - Use a <nav> element for the header links.
    - Change the frontend code to delay setting up the routes until the basic
    elements of the page are fetched from the server.
    - Added a spinner while the main data is loading.
    - Added the admin link (which currently doesn't do anything, but that's next
    up).
    - Changed various URLs so that endpoints that return JSON are all under /api/
    - Indentation fixes.

    Verified that everything still works as expected.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/x-student-view.js
          lib/frontend/main.js
          views/login.handlebars
          lib/frontend/router.js
          css/style.less
          lib/routes.js
          views/layouts/main.handlebars
      
      
      
      Tool: Pyflakes
      Ignored Files:
          lib/frontend/x-student-view.js
          lib/frontend/main.js
          views/login.handlebars
          lib/frontend/router.js
          css/style.less
          lib/routes.js
          views/layouts/main.handlebars
      
      
    2. 
        
    david
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/x-student-view.js
          lib/frontend/main.js
          views/login.handlebars
          lib/schema.js
          lib/frontend/router.js
          css/style.less
          lib/routes.js
          views/layouts/main.handlebars
      
      
      
      Tool: Pyflakes
      Ignored Files:
          lib/frontend/x-student-view.js
          lib/frontend/main.js
          views/login.handlebars
          lib/schema.js
          lib/frontend/router.js
          css/style.less
          lib/routes.js
          views/layouts/main.handlebars
      
      
    2. 
        
    david
    Review request changed
    Status:
    Discarded