Summary

Fix an UnboundLocalError when using --diff-filename.

Review Request #7482 — Created July 3, 2015 and submitted July 7, 2015, 1:51 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-0.6.x

Bugs

3908

Depends On

Commit

9d95189...

Reviewers

Groups

rbtools

People

Description

The calculation of the changenum/commit ID was trying to reference a variable
that wasn't set using --diff-filename. This change fixes it.

Testing Done

Posted this change using --diff-filename.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/post.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/post.py

Ship it!

```
Ship It!
```

rbtools/commands/post.py (Diff revision 1)

I have a naive question (mostly because I'm not familiar with SCMs where supports_changesets is true). I agree that this fix resolves the crash from the bug report, but isn't there a secondary component whereby changenum really does need need to be set to a legit value (the parameter from the command line) for the subsequent call to post_request()?

david July 7, 2015, 1:51 p.m.

I don't think we've ever properly supported --diff-filename on SCMs that use changenums. We probably should, but that should be a separate change.

gmyers July 7, 2015, 5:11 p.m.

My read on the bug report, is that this is really the issue the author was getting at.  He claims this worked in 0.5.2 and skimming the code at line 636 (https://github.com/reviewboard/rbtools/blob/release-0.5.x/rbtools/commands/post.py#L636) I might agree with him, although I do not have a way to test and verify this.

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (8ec9937)