Remove some old, unneeded bits from the webapi codebase.

 






 

 


  Review Request #7480
  —
  Created July 3, 2015 and submitted 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 









 
 

  cff5c29...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
We had an old deprecated API encoder sitting around in the codebase for

the old API, which we no longer ship. That's been removed.


Our resources also used a _no_access_error() method in WebAPIResource,

which we have since ported over to the actual Djblets WebAPIResource

(and renamed). All call sites have been updated for the new method, and

the old one has been removed.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 









 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/draft_original_file.py
    reviewboard/webapi/resources/review_group.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_watched_object.py
    reviewboard/webapi/resources/review_reply_diff_comment.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/base_archived_object.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/review_request_last_update.py
    reviewboard/webapi/resources/draft_filediff.py
    reviewboard/webapi/resources/review_reply_screenshot_comment.py
    reviewboard/webapi/resources/api_token.py
    reviewboard/webapi/resources/base_comment.py
    reviewboard/webapi/resources/patched_file.py
    reviewboard/webapi/resources/review_screenshot_comment.py
    reviewboard/webapi/resources/default_reviewer.py
    reviewboard/webapi/resources/original_file.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/webapi/base.py
    reviewboard/webapi/resources/draft_patched_file.py
    reviewboard/webapi/resources/base_screenshot.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/review_group_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/repository.py
    reviewboard/webapi/resources/draft_original_file.py
    reviewboard/webapi/resources/review_group.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/webapi/resources/review_request.py
    reviewboard/webapi/resources/base_watched_object.py
    reviewboard/webapi/resources/review_reply_diff_comment.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/hosting_service_account.py
    reviewboard/webapi/resources/review_reply.py
    reviewboard/webapi/resources/base_archived_object.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/encoder.py
    reviewboard/webapi/resources/review_reply_file_attachment_comment.py
    reviewboard/webapi/resources/review_file_attachment_comment.py
    reviewboard/webapi/resources/review_request_last_update.py
    reviewboard/webapi/resources/draft_filediff.py
    reviewboard/webapi/resources/review_reply_screenshot_comment.py
    reviewboard/webapi/resources/api_token.py
    reviewboard/webapi/resources/base_comment.py
    reviewboard/webapi/resources/patched_file.py
    reviewboard/webapi/resources/review_screenshot_comment.py
    reviewboard/webapi/resources/default_reviewer.py
    reviewboard/webapi/resources/original_file.py
    reviewboard/webapi/resources/base_review.py
    reviewboard/webapi/resources/review_diff_comment.py
    reviewboard/webapi/base.py
    reviewboard/webapi/resources/draft_patched_file.py
    reviewboard/webapi/resources/base_screenshot.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/review_group_user.py


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-2.5.x (420b477)





 


 










  

 









     

    

   

  

  

   
   Loading...