Split djblets.webapi.resources into sub-modules.

Review Request #7472 — Created July 1, 2015 and submitted

Information

Djblets
release-0.9.x
e2416b7...

Reviewers

This is the second part of the djblets.webapi cleanup. This change takes
djblets.webapi.resources, which contained WebAPIResource, UserResource,
GroupResource, RootResource, and all the resource registration
functions, and moves them out into new submodules.

This will make it easier to bundle and maintain new built-in resources
for different purposes, and to keep the code more organized.

The old djblets.webapi.resources still works. It imports all the
original classes/functions, and triggers a deprecation warning when
imported.

Docstrings have been updated for most of this to conform with the new
codebase docs format we're using, but I didn't do this everywhere.
WebAPIResource is largely untouched, except for formatting errors for
lists.

Unit tests pass on both Djblets and Review Board.

Built the docs and looked through them. Not everything is perfect, but
all the new/fixed content looks correct.

Description From Last Updated

Col: 47 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 47 E128 continuation line under-indented for visual indent

reviewbotreviewbot

"An resource" isn't correct.

daviddavid

Should have an extra blank line here.

daviddavid

Should be "Retrieve"

daviddavid

Should be "Retrieve"

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
  2. djblets/webapi/resources/base.py (Diff revision 1)
     
     
    Show all issues
    Col: 47
     E128 continuation line under-indented for visual indent
    
  3. djblets/webapi/resources/base.py (Diff revision 1)
     
     
    Show all issues
    Col: 47
     E128 continuation line under-indented for visual indent
    
  4. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
  2. 
      
david
  1. The interdiff between r1 and r2 seems wrong.

    1. Yeah I dunno what's with that. The only change was an indentation-only change, and I bet we're doing something wrong there. Problem for another day.

  2. 
      
david
  1. 
      
  2. djblets/webapi/resources/base.py (Diff revision 2)
     
     
    Show all issues

    "An resource" isn't correct.

  3. djblets/webapi/resources/group.py (Diff revision 2)
     
     
    Show all issues

    Should have an extra blank line here.

  4. djblets/webapi/resources/root.py (Diff revision 2)
     
     
    Show all issues

    Should be "Retrieve"

  5. djblets/webapi/resources/user.py (Diff revision 2)
     
     
    Show all issues

    Should be "Retrieve"

  6. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/webapi/resources/group.py
        djblets/webapi/resources/root.py
        djblets/webapi/resources/registry.py
        djblets/webapi/resources/base.py
        djblets/webapi/resources/user.py
        djblets/webapi/resources/__init__.py
    
    Ignored Files:
        docs/djblets/coderef/index.rst
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.9.x (4f1c696)
Loading...