Summary

Add breaks to "Review request changed"

Review Request #747 — Created Feb. 19, 2009 and discarded

Information

Owner

tphams

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add breaks to "Review request changed". It was hard to read and see the difference, especially with long description. Maybe including each in < pre > is even better, at the cost of more real estate.

Testing Done

```
Much nicer. Works for me.
```

/trunk/reviewboard/templates/reviews/review_detail.html (Diff revision 1)

This is XHTML, so you'd have to use <br /> instead of <br>.

I'd rather see this done with <pre> tags (as you mentioned) and <p> for the "changed from:" part. <br /> shouldn't be used for separating paragraphs.

Change Summary:

Updated as commented

Diff:

Revision 2 (+1 -1)

Show changes

/trunk/reviewboard/templates/reviews/review_detail.html

Thanks for the change. I ended up tackling this a different way. It's set up to provide a completely different handler for these two fields, in such a way where we can extend this later for other fields.