Simplify the display of file attachment comments a bit.

Review Request #7456 — Created June 25, 2015 and submitted

Information

Review Board
release-2.5.x
ca10bbe...

Reviewers

Most of the file attachment stuff has had a visual revamp. This change cleans
up the last vestiges of stuff in the review dialog and review boxes: namely, we
don't care so much about displaying both the filename and the caption, in favor
of a unified "display name" for the attachment. We've also deprecated the file
type icons just about everywhere, so this removes it from the review box too.

This also removes the now-unused file_attachment_thumbnail.html template.

  • Checked the display of file attachment comments everywhere and saw that they
    looked correct.
  • Ran unit tests.
  • Ran js-tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/models/file_attachment_comment.py
    
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/templates/reviews/file_attachment_thumbnail.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/ui/base.py
        reviewboard/reviews/models/file_attachment_comment.py
    
    Ignored Files:
        reviewboard/templates/reviews/boxes/review.html
        reviewboard/templates/reviews/file_attachment_thumbnail.html
    
    
  2. 
      
chipx86
  1. Screenshots?

  2. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (fd7148e)
Loading...