Fix incorrectly interpreting newly-saved text as HTML in replies.

Review Request #7451 — Created June 24, 2015 and submitted

Information

Review Board
release-2.0.x
491eefe...

Reviewers

When saving a reply, the text and then the richText properties would be
set. The view listened to both, and updated the rendered text each time
one was emitted. This led to a brief moment where the newly-saved text
was being interpreted incorrectly, right before being set properly.

If entering a script tag, this would execute the script. However, this
would only ever happen locally, during the save process, and would not
affect other users, nor would it execute when reloading the page.

We now have a signal used for updating the text, which we can listen to
instead, in order to update the rendered text only once.

Replied with a script tag, and saw that it rendered correctly, without
executing the script.

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/reviewReplyEditorView.js
        reviewboard/static/rb/js/models/reviewReplyEditorModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/reviewReplyEditorView.js
        reviewboard/static/rb/js/models/reviewReplyEditorModel.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (c4c2a4e)
Loading...