Use `diff` command for TFS.

Review Request #7450 — Created June 24, 2015 and submitted

Information

RBTools
release-0.7.x
c990bc2...

Reviewers

It turns out that difflib's unified diff implementation, while seemingly okay,
chokes pretty badly with files that don't end in newlines, or start with
byte-order markers. After piling workaround on top of workaround, I've decided
to rip it out and just use the diffutils diff command.

Posted some changes containing previously problematic files. Saw that they all
worked.

Description From Last Updated

Shouldn't this use b'..'?

chipx86chipx86

What happens here if old_label and new_label are bytestrings, since they're then mixing with Unicode strings?

chipx86chipx86

Change this comment to reflect that we're no longer using difflib.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tfs.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tfs.py
    
    
  2. 
      
chipx86
  1. 
      
  2. rbtools/clients/tfs.py (Diff revision 1)
     
     
     

    Shouldn't this use b'..'?

  3. rbtools/clients/tfs.py (Diff revision 1)
     
     

    What happens here if old_label and new_label are bytestrings, since they're then mixing with Unicode strings?

  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tfs.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tfs.py
    
    
  2. 
      
brennie
  1. 
      
  2. rbtools/clients/tfs.py (Diff revision 2)
     
     
     

    Change this comment to reflect that we're no longer using difflib.

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/tfs.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/tfs.py
    
    
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (03b42f1)
Loading...