Fixed GitDiffParser mis-parsing git patch files

Review Request #745 — Created Feb. 12, 2009 and submitted

Information

Review Board SVN (deprecated)

Reviewers

When a new file is added into git, the path in the patch file doesn't have a "a/" or "b/" prepended to it. Replacing the foo[2:] with re.sub("^[a|b]/", "", foo) fixes the issue.

A couple more details here: http://code.google.com/p/reviewboard/issues/detail?id=883

 
AN
Review request changed

Description:

   

When a new file is added into git, the path in the patch file doesn't have a "a/" or "b/" prepended to it. Replacing the foo[2:] with re.sub("^[a|b]/", "", foo) fixes the issue.

  +
  +

A couple more details here: http://code.google.com/p/reviewboard/issues/detail?id=883

PE
  1. ????????
    ????
    
  2. 
      
chipx86
  1. Looks great. Committed as r1814.
  2. 
      
Loading...